Quantcast

[aerogear-dev] Variant Updates return 200 but docs say 204

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[aerogear-dev] Variant Updates return 200 but docs say 204

Luke Holmquist
The variant update endpoint returns a 200 with the updated content, but the docs says it should return a 204 with no Content

i've create a JIRA for it,  https://issues.jboss.org/browse/AGPUSH-1635


I think PUT's are suppose to be 204's, but there might be things relying on the fact that the update returns data,

here is a link to the AndroidVariants update endpoint,  https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L142

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [aerogear-dev] Variant Updates return 200 but docs say 204

Matthias Wessendorf
we changed that last year:

Systems that integrate with the UPS might appreciate the actual response data of the updated entity, so we moved to 200 status code.

The doc is broken. Good find Luke. 

Mind sending a doc patch ? 

On Thu, May 19, 2016 at 9:21 PM, Luke Holmquist <[hidden email]> wrote:
The variant update endpoint returns a 200 with the updated content, but the docs says it should return a 204 with no Content

i've create a JIRA for it,  https://issues.jboss.org/browse/AGPUSH-1635


I think PUT's are suppose to be 204's, but there might be things relying on the fact that the update returns data,

here is a link to the AndroidVariants update endpoint,  https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L142

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [aerogear-dev] Variant Updates return 200 but docs say 204

Luke Holmquist


On Thu, May 19, 2016 at 4:09 PM, Matthias Wessendorf <[hidden email]> wrote:

i thought it sounded familiar


Systems that integrate with the UPS might appreciate the actual response data of the updated entity, so we moved to 200 status code.

The doc is broken. Good find Luke. 

Mind sending a doc patch ? 

Doc Patch incoming

On Thu, May 19, 2016 at 9:21 PM, Luke Holmquist <[hidden email]> wrote:
The variant update endpoint returns a 200 with the updated content, but the docs says it should return a 204 with no Content

i've create a JIRA for it,  https://issues.jboss.org/browse/AGPUSH-1635


I think PUT's are suppose to be 204's, but there might be things relying on the fact that the update returns data,

here is a link to the AndroidVariants update endpoint,  https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L142

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [aerogear-dev] Variant Updates return 200 but docs say 204

Luke Holmquist

On Thu, May 19, 2016 at 4:10 PM, Luke Holmquist <[hidden email]> wrote:


On Thu, May 19, 2016 at 4:09 PM, Matthias Wessendorf <[hidden email]> wrote:

i thought it sounded familiar


Systems that integrate with the UPS might appreciate the actual response data of the updated entity, so we moved to 200 status code.

The doc is broken. Good find Luke. 

Mind sending a doc patch ? 

Doc Patch incoming

On Thu, May 19, 2016 at 9:21 PM, Luke Holmquist <[hidden email]> wrote:
The variant update endpoint returns a 200 with the updated content, but the docs says it should return a 204 with no Content

i've create a JIRA for it,  https://issues.jboss.org/browse/AGPUSH-1635


I think PUT's are suppose to be 204's, but there might be things relying on the fact that the update returns data,

here is a link to the AndroidVariants update endpoint,  https://github.com/aerogear/aerogear-unifiedpush-server/blob/master/jaxrs/src/main/java/org/jboss/aerogear/unifiedpush/rest/registry/applications/AndroidVariantEndpoint.java#L142

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Loading...