[aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Summers Pittman
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Karel Piwko
Hello Summers,

my concern would be that this repo is Ant based and not available in Maven Central. So a fork would indeed be needed. Other problem is that the lib does not support supplying backend server location - but this is something a PR can fix. In the past, I believe that we evaluated this library as an option as well https://github.com/phonedeck/gcm4j

Cheers,

Karel


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Summers Pittman
Right now I've taken the library, replaced and with maven, removed the samples, and slapped some topic support into it.  I'll commit to my repo for review at some point today.

On Mon, Aug 3, 2015 at 10:33 AM, Karel Piwko <[hidden email]> wrote:
Hello Summers,

my concern would be that this repo is Ant based and not available in Maven Central. So a fork would indeed be needed. Other problem is that the lib does not support supplying backend server location - but this is something a PR can fix. In the past, I believe that we evaluated this library as an option as well https://github.com/phonedeck/gcm4j

Cheers,

Karel


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Summers Pittman
In reply to this post by Karel Piwko


On Mon, Aug 3, 2015 at 10:33 AM, Karel Piwko <[hidden email]> wrote:
Hello Summers,

my concern would be that this repo is Ant based and not available in Maven Central. So a fork would indeed be needed. Other problem is that the lib does not support supplying backend server location -
What do you mean? 
but this is something a PR can fix. In the past, I believe that we evaluated this library as an option as well https://github.com/phonedeck/gcm4j

Cheers,

Karel


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Karel Piwko
I mean https://github.com/google/gcm/blob/master/client-libraries/java/rest-client/src/com/google/android/gcm/server/Constants.java#L27 which makes impossible to replace GCM backend with mocked backend for testing purposes. Other messaging provider libraries allow that.

Karel

On Mon, Aug 3, 2015 at 6:46 PM, Summers Pittman <[hidden email]> wrote:


On Mon, Aug 3, 2015 at 10:33 AM, Karel Piwko <[hidden email]> wrote:
Hello Summers,

my concern would be that this repo is Ant based and not available in Maven Central. So a fork would indeed be needed. Other problem is that the lib does not support supplying backend server location -
What do you mean? 
but this is something a PR can fix. In the past, I believe that we evaluated this library as an option as well https://github.com/phonedeck/gcm4j

Cheers,

Karel


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Matthias Wessendorf
In reply to this post by Summers Pittman


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

This would a work-around, but ultimately we wanna use (or create) a GCM-XMPP library, to be used in UPS, right ? 

Sure, if that takes a bit more time, let's get this scheduled for 1.3. I think moving to XMPP, will also improve send performance, since we have one connection (pool) instead of countless HTTP requests

-M
 

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] UPS 1.2, GCM 3.0 Topics, and Google's rest-client updates

Summers Pittman
In reply to this post by Karel Piwko


On Tue, Aug 4, 2015 at 3:36 PM, Karel Piwko <[hidden email]> wrote:
I mean https://github.com/google/gcm/blob/master/client-libraries/java/rest-client/src/com/google/android/gcm/server/Constants.java#L27 which makes impossible to replace GCM backend with mocked backend for testing purposes. Other messaging provider libraries allow that.


So basically Karel you are saying that their library is unsuited for our applications without some serious modification?

Right now in the Topics PR I have a branched, snipped, and (slightly) refactored maven version.  Feel free to give you feedback there.

Karel

On Mon, Aug 3, 2015 at 6:46 PM, Summers Pittman <[hidden email]> wrote:


On Mon, Aug 3, 2015 at 10:33 AM, Karel Piwko <[hidden email]> wrote:
Hello Summers,

my concern would be that this repo is Ant based and not available in Maven Central. So a fork would indeed be needed. Other problem is that the lib does not support supplying backend server location -
What do you mean? 
but this is something a PR can fix. In the past, I believe that we evaluated this library as an option as well https://github.com/phonedeck/gcm4j

Cheers,

Karel


On Fri, Jul 31, 2015 at 5:04 PM, Summers Pittman <[hidden email]> wrote:
Guys and gals,

UPS is currently using a fork of Google's rest-client sample to communicate with Google's servers (See the previous thread UPS and com.ganyo:gcm-server for details**).  This is an outdated fork from https://github.com/google/gcm.  

It is in fact very outdated.  The rest client code, Message and Builder objects, Constant fields, and Sender code don't support all of the fields/errors/etc needed for GCM topics messaging.  Additionally it uses a deprecated field in a few places.  I've filed two* issues*** in the gcm project to reach out and begin work with them to resolve this in a more sane way.  In the meanwhile we will probably have to patch and support our own fork of the library.

Thoughts, comments, tomatoes?

PS, this will probably bump XMPP support from aerogear-android-push 3.0 and UPS 1.2.  Please let me know if it should and i will pull those from the JIRA epics and we can reschedule them.

Summers


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev