[aerogear-dev] AGDroid-Push:4.0.1 release (was Re: FCM: Cordova/Android bug ?)

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[aerogear-dev] AGDroid-Push:4.0.1 release (was Re: FCM: Cordova/Android bug ?)

Matthias Wessendorf
Hello,

this little bug was fixed, and a 4.0.1 will hit Maven Central soon.


I've already update our Android HelloWorld demo:

as well the Cordova plugin:

Happy testing :) 


On Mon, Jun 20, 2016 at 1:31 PM, Matthias Wessendorf <[hidden email]> wrote:

On Mon, Jun 20, 2016 at 1:27 PM, Matthias Wessendorf <[hidden email]> wrote:
I have seen that with a native app now too.

I will create a JIRA 

On Mon, Jun 20, 2016 at 11:01 AM, Oleg Matskiv <[hidden email]> wrote:
And instanceId.getToken() indeed returned null on first registration.
So native unified-push-helloworld app [1] can be used to reproduce this issue.

[1] https://github.com/jboss-mobile/unified-push-helloworld

On Mon, Jun 20, 2016 at 10:40 AM, Oleg Matskiv <[hidden email]> wrote:
Hi,

I had very similar problem with native app (unified-push-helloworld), 400 code on first registration.
I'll check getToken() return value to verify that its actually same issue.

On Mon, Jun 20, 2016 at 10:28 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
I think that should be enough, if the plugin uses the AGPush lib and the lib has that on the AndroidManifest, it should be merged with the app AndroidManifest. In the end a Cordova app is an Android app, it should work the same way the Android app works

On Mon, Jun 20, 2016 at 10:02 AM, Matthias Wessendorf <[hidden email]> wrote:
Ok, so IMO that sounds like a bug in the Android lib, so the UPS registration should be fired after 'onTokenRefresh' is called

Also, cordova question. Do we need to define our "UnifiedPushInstanceIDListenerService" in the plugin's config section for the manifest? Or is this, inside the AGPush lib good enough ?

Thanks,
Matthias

On Mon, Jun 20, 2016 at 9:46 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
Yes, getToken will return null until onTokenRefresh is called the first time when it gets the real value.

On Mon, Jun 20, 2016 at 9:06 AM, Matthias Wessendorf <[hidden email]> wrote:

On Sun, Jun 19, 2016 at 8:39 PM, Matthias Wessendorf <[hidden email]> wrote:
Looking at the JavaDoc for the getToken():

"the master token or null if the token is not yet available"

looks like on the android lib we should not have it return null ?

On Sat, Jun 18, 2016 at 3:17 PM, Matthias Wessendorf <[hidden email]> wrote:
Hi,

when I launch a fresh and clean Cordova app (I am unable to reproduce this on our native Android HelloWorld), and open it the first time for registration, I am receiving a 400 status code from the server.

Uninstalling the app, and launching it again, show the the problem again, ONLY on Cordova...

This means either the deviceToken from Android is null or invalid (according to the pattern):

Doing some debugging, on the server, I see the provided token is actually null.

Is there a race condition or so on the client, for the initial launch of the app ? 

I added some logging on the client (see [1]), and indeed, it looks like, on Cordova, it is actually null:

Now... a few lines above... I see 'outdated' c2dm packages/permissions, and a GCM: "Missmatched messenger", it looks like something is still not correct.

Any thoughts ? 

-Matthias 




--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] AGDroid-Push:4.0.1 release (was Re: FCM: Cordova/Android bug ?)

Oleh Mackiv
Hello,

I have just tested it with native app and it worked perfectly. *thumbs-up*


On Mon, Jun 20, 2016 at 5:57 PM, Matthias Wessendorf <[hidden email]> wrote:
Hello,

this little bug was fixed, and a 4.0.1 will hit Maven Central soon.


I've already update our Android HelloWorld demo:

as well the Cordova plugin:

Happy testing :) 


On Mon, Jun 20, 2016 at 1:31 PM, Matthias Wessendorf <[hidden email]> wrote:

On Mon, Jun 20, 2016 at 1:27 PM, Matthias Wessendorf <[hidden email]> wrote:
I have seen that with a native app now too.

I will create a JIRA 

On Mon, Jun 20, 2016 at 11:01 AM, Oleg Matskiv <[hidden email]> wrote:
And instanceId.getToken() indeed returned null on first registration.
So native unified-push-helloworld app [1] can be used to reproduce this issue.

[1] https://github.com/jboss-mobile/unified-push-helloworld

On Mon, Jun 20, 2016 at 10:40 AM, Oleg Matskiv <[hidden email]> wrote:
Hi,

I had very similar problem with native app (unified-push-helloworld), 400 code on first registration.
I'll check getToken() return value to verify that its actually same issue.

On Mon, Jun 20, 2016 at 10:28 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
I think that should be enough, if the plugin uses the AGPush lib and the lib has that on the AndroidManifest, it should be merged with the app AndroidManifest. In the end a Cordova app is an Android app, it should work the same way the Android app works

On Mon, Jun 20, 2016 at 10:02 AM, Matthias Wessendorf <[hidden email]> wrote:
Ok, so IMO that sounds like a bug in the Android lib, so the UPS registration should be fired after 'onTokenRefresh' is called

Also, cordova question. Do we need to define our "UnifiedPushInstanceIDListenerService" in the plugin's config section for the manifest? Or is this, inside the AGPush lib good enough ?

Thanks,
Matthias

On Mon, Jun 20, 2016 at 9:46 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
Yes, getToken will return null until onTokenRefresh is called the first time when it gets the real value.

On Mon, Jun 20, 2016 at 9:06 AM, Matthias Wessendorf <[hidden email]> wrote:

On Sun, Jun 19, 2016 at 8:39 PM, Matthias Wessendorf <[hidden email]> wrote:
Looking at the JavaDoc for the getToken():

"the master token or null if the token is not yet available"

looks like on the android lib we should not have it return null ?

On Sat, Jun 18, 2016 at 3:17 PM, Matthias Wessendorf <[hidden email]> wrote:
Hi,

when I launch a fresh and clean Cordova app (I am unable to reproduce this on our native Android HelloWorld), and open it the first time for registration, I am receiving a 400 status code from the server.

Uninstalling the app, and launching it again, show the the problem again, ONLY on Cordova...

This means either the deviceToken from Android is null or invalid (according to the pattern):

Doing some debugging, on the server, I see the provided token is actually null.

Is there a race condition or so on the client, for the initial launch of the app ? 

I added some logging on the client (see [1]), and indeed, it looks like, on Cordova, it is actually null:

Now... a few lines above... I see 'outdated' c2dm packages/permissions, and a GCM: "Missmatched messenger", it looks like something is still not correct.

Any thoughts ? 

-Matthias 




--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] AGDroid-Push:4.0.1 release (was Re: FCM: Cordova/Android bug ?)

Matthias Wessendorf
Ok, shipping to maven central 

On Tue, Jun 21, 2016 at 11:00 AM, Oleg Matskiv <[hidden email]> wrote:
Hello,

I have just tested it with native app and it worked perfectly. *thumbs-up*


On Mon, Jun 20, 2016 at 5:57 PM, Matthias Wessendorf <[hidden email]> wrote:
Hello,

this little bug was fixed, and a 4.0.1 will hit Maven Central soon.


I've already update our Android HelloWorld demo:

as well the Cordova plugin:

Happy testing :) 


On Mon, Jun 20, 2016 at 1:31 PM, Matthias Wessendorf <[hidden email]> wrote:

On Mon, Jun 20, 2016 at 1:27 PM, Matthias Wessendorf <[hidden email]> wrote:
I have seen that with a native app now too.

I will create a JIRA 

On Mon, Jun 20, 2016 at 11:01 AM, Oleg Matskiv <[hidden email]> wrote:
And instanceId.getToken() indeed returned null on first registration.
So native unified-push-helloworld app [1] can be used to reproduce this issue.

[1] https://github.com/jboss-mobile/unified-push-helloworld

On Mon, Jun 20, 2016 at 10:40 AM, Oleg Matskiv <[hidden email]> wrote:
Hi,

I had very similar problem with native app (unified-push-helloworld), 400 code on first registration.
I'll check getToken() return value to verify that its actually same issue.

On Mon, Jun 20, 2016 at 10:28 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
I think that should be enough, if the plugin uses the AGPush lib and the lib has that on the AndroidManifest, it should be merged with the app AndroidManifest. In the end a Cordova app is an Android app, it should work the same way the Android app works

On Mon, Jun 20, 2016 at 10:02 AM, Matthias Wessendorf <[hidden email]> wrote:
Ok, so IMO that sounds like a bug in the Android lib, so the UPS registration should be fired after 'onTokenRefresh' is called

Also, cordova question. Do we need to define our "UnifiedPushInstanceIDListenerService" in the plugin's config section for the manifest? Or is this, inside the AGPush lib good enough ?

Thanks,
Matthias

On Mon, Jun 20, 2016 at 9:46 AM, Julio Cesar Sanchez Hernandez <[hidden email]> wrote:
Yes, getToken will return null until onTokenRefresh is called the first time when it gets the real value.

On Mon, Jun 20, 2016 at 9:06 AM, Matthias Wessendorf <[hidden email]> wrote:

On Sun, Jun 19, 2016 at 8:39 PM, Matthias Wessendorf <[hidden email]> wrote:
Looking at the JavaDoc for the getToken():

"the master token or null if the token is not yet available"

looks like on the android lib we should not have it return null ?

On Sat, Jun 18, 2016 at 3:17 PM, Matthias Wessendorf <[hidden email]> wrote:
Hi,

when I launch a fresh and clean Cordova app (I am unable to reproduce this on our native Android HelloWorld), and open it the first time for registration, I am receiving a 400 status code from the server.

Uninstalling the app, and launching it again, show the the problem again, ONLY on Cordova...

This means either the deviceToken from Android is null or invalid (according to the pattern):

Doing some debugging, on the server, I see the provided token is actually null.

Is there a race condition or so on the client, for the initial launch of the app ? 

I added some logging on the client (see [1]), and indeed, it looks like, on Cordova, it is actually null:

Now... a few lines above... I see 'outdated' c2dm packages/permissions, and a GCM: "Missmatched messenger", it looks like something is still not correct.

Any thoughts ? 

-Matthias 




--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--
Oleg Matskiv
Associate Quality Engineer
Red Hat Mobile Application Platform
[hidden email]

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev