Re: [aerogear-dev] Jenkins Java client - fork?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] Jenkins Java client - fork?

Matthias Wessendorf
Hey,

I just replied to Wei's mail, which addresses a similar concern. If a dependency is not properly maintained, and released, there is always room for that kinda stuff.
If we do it, we should be doing it w/ different packages (e.g. org.aerogear.com.offbytwo.jenkins), as a last resort :-) 

I'd suggest to get in touch w/ the maintainer, and explain him, that we are interested in helping, and would also like to have frequent releases :) Perhaps that's the first strategy, before going hard on a fork - that has the risk of being always different than the rest of the usptream community. 


-M


On Thu, Jun 1, 2017 at 5:28 PM, Ali Ok <[hidden email]> wrote:
Hi,

In order to make our Digger Java client working as we like, we needed to make changes in the underlying Jenkins Java client [1].
We sent a PR, but we don't know when the project owner will merge it. So, for testing purposes of our own, we would like to release our fork of Jenkins Java client in a snapshot repository.

What do you say? Any other and better approach?

Where can we publish the snapshots of our fork?

Note: The project owner is a kind guy and will perhaps publish a snapshot release for us after merging our PR, but we cannot rely on that workflow for long time for other needed changes.

--

ALI OK

SENIOR SOFTWARE ENGINEER, RED HAT MOBILE APPLICATION PLATFORM

Red Hat 


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] Jenkins Java client - fork?

Matthias Wessendorf
Ali, Wei,

if we fork it, I'd strongly suggest to use the aerogear Github org, not the feedhenry one. It feels a bit weird using two different GH orgs for one project and its fork/dependency

On Fri, Jun 2, 2017 at 7:54 AM, Matthias Wessendorf <[hidden email]> wrote:
Hey,

I just replied to Wei's mail, which addresses a similar concern. If a dependency is not properly maintained, and released, there is always room for that kinda stuff.
If we do it, we should be doing it w/ different packages (e.g. org.aerogear.com.offbytwo.jenkins), as a last resort :-) 

I'd suggest to get in touch w/ the maintainer, and explain him, that we are interested in helping, and would also like to have frequent releases :) Perhaps that's the first strategy, before going hard on a fork - that has the risk of being always different than the rest of the usptream community. 


-M


On Thu, Jun 1, 2017 at 5:28 PM, Ali Ok <[hidden email]> wrote:
Hi,

In order to make our Digger Java client working as we like, we needed to make changes in the underlying Jenkins Java client [1].
We sent a PR, but we don't know when the project owner will merge it. So, for testing purposes of our own, we would like to release our fork of Jenkins Java client in a snapshot repository.

What do you say? Any other and better approach?

Where can we publish the snapshots of our fork?

Note: The project owner is a kind guy and will perhaps publish a snapshot release for us after merging our PR, but we cannot rely on that workflow for long time for other needed changes.

--

ALI OK

SENIOR SOFTWARE ENGINEER, RED HAT MOBILE APPLICATION PLATFORM

Red Hat 


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] Jenkins Java client - fork?

Wei Li
Completely agree. I just noticed it is already forked in the AG org here: https://github.com/aerogear/java-client-api.

I will remove the one from FeedHenry GH org.

On Fri, Jun 2, 2017 at 6:57 AM, Matthias Wessendorf <[hidden email]> wrote:
Ali, Wei,

if we fork it, I'd strongly suggest to use the aerogear Github org, not the feedhenry one. It feels a bit weird using two different GH orgs for one project and its fork/dependency

On Fri, Jun 2, 2017 at 7:54 AM, Matthias Wessendorf <[hidden email]> wrote:
Hey,

I just replied to Wei's mail, which addresses a similar concern. If a dependency is not properly maintained, and released, there is always room for that kinda stuff.
If we do it, we should be doing it w/ different packages (e.g. org.aerogear.com.offbytwo.jenkins), as a last resort :-) 

I'd suggest to get in touch w/ the maintainer, and explain him, that we are interested in helping, and would also like to have frequent releases :) Perhaps that's the first strategy, before going hard on a fork - that has the risk of being always different than the rest of the usptream community. 


-M


On Thu, Jun 1, 2017 at 5:28 PM, Ali Ok <[hidden email]> wrote:
Hi,

In order to make our Digger Java client working as we like, we needed to make changes in the underlying Jenkins Java client [1].
We sent a PR, but we don't know when the project owner will merge it. So, for testing purposes of our own, we would like to release our fork of Jenkins Java client in a snapshot repository.

What do you say? Any other and better approach?

Where can we publish the snapshots of our fork?

Note: The project owner is a kind guy and will perhaps publish a snapshot release for us after merging our PR, but we cannot rely on that workflow for long time for other needed changes.

--

ALI OK

SENIOR SOFTWARE ENGINEER, RED HAT MOBILE APPLICATION PLATFORM

Red Hat 


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

WEI LI

SENIOR SOFTWARE ENGINEER

Red Hat Mobile

[hidden email]    M: <a href="tel:+353862393272" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+353862393272    


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev
Reply | Threaded
Open this post in threaded view
|

Re: [aerogear-dev] Jenkins Java client - fork?

Wei Li
@Matthias can you give me write access to this repo: https://github.com/aerogear/java-client-api. Thanks.

On Fri, Jun 2, 2017 at 11:33 AM, Wei Li <[hidden email]> wrote:
Completely agree. I just noticed it is already forked in the AG org here: https://github.com/aerogear/java-client-api.

I will remove the one from FeedHenry GH org.

On Fri, Jun 2, 2017 at 6:57 AM, Matthias Wessendorf <[hidden email]> wrote:
Ali, Wei,

if we fork it, I'd strongly suggest to use the aerogear Github org, not the feedhenry one. It feels a bit weird using two different GH orgs for one project and its fork/dependency

On Fri, Jun 2, 2017 at 7:54 AM, Matthias Wessendorf <[hidden email]> wrote:
Hey,

I just replied to Wei's mail, which addresses a similar concern. If a dependency is not properly maintained, and released, there is always room for that kinda stuff.
If we do it, we should be doing it w/ different packages (e.g. org.aerogear.com.offbytwo.jenkins), as a last resort :-) 

I'd suggest to get in touch w/ the maintainer, and explain him, that we are interested in helping, and would also like to have frequent releases :) Perhaps that's the first strategy, before going hard on a fork - that has the risk of being always different than the rest of the usptream community. 


-M


On Thu, Jun 1, 2017 at 5:28 PM, Ali Ok <[hidden email]> wrote:
Hi,

In order to make our Digger Java client working as we like, we needed to make changes in the underlying Jenkins Java client [1].
We sent a PR, but we don't know when the project owner will merge it. So, for testing purposes of our own, we would like to release our fork of Jenkins Java client in a snapshot repository.

What do you say? Any other and better approach?

Where can we publish the snapshots of our fork?

Note: The project owner is a kind guy and will perhaps publish a snapshot release for us after merging our PR, but we cannot rely on that workflow for long time for other needed changes.

--

ALI OK

SENIOR SOFTWARE ENGINEER, RED HAT MOBILE APPLICATION PLATFORM

Red Hat 


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--



--

_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev



--

WEI LI

SENIOR SOFTWARE ENGINEER

Red Hat Mobile

[hidden email]    M: <a href="tel:+353862393272" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+353862393272    




--

WEI LI

SENIOR SOFTWARE ENGINEER

Red Hat Mobile

[hidden email]    M: <a href="tel:+353862393272" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+353862393272    


_______________________________________________
aerogear-dev mailing list
[hidden email]
https://lists.jboss.org/mailman/listinfo/aerogear-dev